Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seata-all to handle cglib breaking unit test execution with GraalVM Tracing Agent #24177

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

linghengqian
Copy link
Member

For #21347.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian
Copy link
Member Author

  • Since Seata 1.4.2 carries cglib that is not compatible with JDK17, it will break class loading when using GraalVM Tracing Agent to execute related unit tests under JVM.
  • 4ac812025b458d2d79f0a0f79dd6088
  • 098f9fc8349fa770d19f106f801d103

@codecov-commenter
Copy link

Codecov Report

Merging #24177 (8cf22f4) into master (c202fe6) will decrease coverage by 0.02%.
The diff coverage is 30.00%.

❗ Current head 8cf22f4 differs from pull request most recent head f897596. Consider uploading reports for the commit f897596 to get more accurate results

@@             Coverage Diff              @@
##             master   #24177      +/-   ##
============================================
- Coverage     50.14%   50.13%   -0.02%     
  Complexity     1579     1579              
============================================
  Files          3258     3258              
  Lines         53512    53513       +1     
  Branches       9853     9856       +3     
============================================
- Hits          26834    26829       -5     
- Misses        24321    24325       +4     
- Partials       2357     2359       +2     
Impacted Files Coverage Δ
...ndler/query/ShowDatabaseDiscoveryRuleExecutor.java 78.57% <0.00%> (-1.43%) ⬇️
...ore/ReadwriteSplittingDistSQLStatementVisitor.java 0.00% <0.00%> (ø)
...l/parser/core/ShardingDistSQLStatementVisitor.java 0.00% <0.00%> (ø)
...jdbc/core/resultset/DatabaseMetaDataResultSet.java 97.24% <ø> (ø)
.../query/ShowShardingTableReferenceRuleExecutor.java 66.66% <50.00%> (ø)
...dler/query/ShowReadwriteSplittingRuleExecutor.java 95.00% <66.66%> (-2.44%) ⬇️
...handler/distsql/ral/hint/enums/HintSourceType.java 0.00% <0.00%> (-42.86%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian linghengqian force-pushed the update-seata branch 2 times, most recently from c2a7f6f to fd8ff78 Compare February 15, 2023 12:45
@linghengqian linghengqian marked this pull request as ready for review February 15, 2023 13:41
@terrymanu terrymanu merged commit d7ccd64 into apache:master Feb 28, 2023
@terrymanu terrymanu added this to the 5.3.2 milestone Feb 28, 2023
@linghengqian linghengqian deleted the update-seata branch February 28, 2023 06:19
@FlyingZC
Copy link
Member

image

FlyingZC added a commit to FlyingZC/shardingsphere that referenced this pull request Feb 28, 2023
strongduanmu pushed a commit that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants