Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TransactionHolder.java #20184

Merged
merged 4 commits into from
Aug 16, 2022
Merged

Conversation

tuichenchuxin
Copy link
Contributor

for #20005

Changes proposed in this pull request:

  • remove TransactionHolder.java

@tuichenchuxin tuichenchuxin marked this pull request as ready for review August 15, 2022 06:32
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #20184 (a46cde9) into master (466002c) will decrease coverage by 0.01%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master   #20184      +/-   ##
============================================
- Coverage     60.97%   60.96%   -0.02%     
  Complexity     2418     2418              
============================================
  Files          3873     3873              
  Lines         54428    54426       -2     
  Branches       7623     7623              
============================================
- Hits          33187    33180       -7     
- Misses        18381    18386       +5     
  Partials       2860     2860              
Impacted Files Coverage Δ
.../dbdiscovery/route/DatabaseDiscoverySQLRouter.java 95.23% <ø> (ø)
...nce/FixedPrimaryReadQueryLoadBalanceAlgorithm.java 60.00% <ø> (ø)
...ransactionRandomReadQueryLoadBalanceAlgorithm.java 66.66% <ø> (ø)
...actionRoundRobinReadQueryLoadBalanceAlgorithm.java 66.66% <ø> (ø)
...ransactionWeightReadQueryLoadBalanceAlgorithm.java 69.38% <ø> (ø)
...e/shardingsphere/shadow/route/ShadowSQLRouter.java 33.33% <ø> (ø)
...phere/sharding/route/engine/ShardingSQLRouter.java 78.94% <ø> (ø)
...hardingsphere/infra/session/ConnectionContext.java 0.00% <0.00%> (ø)
...sion/transaction/TransactionConnectionContext.java 0.00% <0.00%> (ø)
...e/infra/route/engine/impl/AllSQLRouteExecutor.java 100.00% <ø> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@strongduanmu strongduanmu merged commit 3bc99d5 into apache:master Aug 16, 2022
@tuichenchuxin tuichenchuxin deleted the ccx-0815 branch September 7, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants