-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature #861][ALL] Remove useless imports #862
Conversation
hi @wuchunfu, can we add some scala checkstyle rule to check it? |
We have a test, but I don’t know why it didn’t take effect this time. Let me try again later. |
I saw it, he only checked java, I will modify it later |
Okay, I will add a |
I think I should submit another pr because there may be more changes after adding |
well, It's better |
cc @CalvinKirs |
plugin: BaseSparkTransform, | ||
ds: Dataset[Row]): Unit = { | ||
plugin: BaseSparkTransform, | ||
ds: Dataset[Row]): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the tab size seems a little long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i will fix it, thx
@@ -80,9 +74,7 @@ object SparkBatchExecution { | |||
ds.createOrReplaceTempView(tableName) | |||
} | |||
|
|||
private[seatunnel] def registerInputTempView( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a nit: I think we can keep it as it is, when the function has many args, the first form is better.
I am not sure if others prefer to the second form.
private[seatunnel] def registerInputTempView(
source: BaseSparkSource[Dataset[Row]],
environment: SparkEnvironment): Unit = {
private[seatunnel] def registerInputTempView(source: BaseSparkSource[Dataset[Row]], environment: SparkEnvironment): Unit = {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I want to restore it? I want to hear your suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also feel that the first one will be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose of this pull request
close #861
Check list