Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector] Add druid sink connector #6346

Merged
merged 40 commits into from
Jun 19, 2024
Merged

Conversation

TaoZex
Copy link
Contributor

@TaoZex TaoZex commented Feb 10, 2024

Purpose of this pull request

#3018

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@TaoZex TaoZex marked this pull request as ready for review February 11, 2024 11:00
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please add docs
  2. Please fix ci error

@TaoZex
Copy link
Contributor Author

TaoZex commented Apr 11, 2024

PTAL @Hisoka-X @EricJoy2048

@TaoZex TaoZex requested a review from Hisoka-X April 12, 2024 06:15
@hailin0
Copy link
Member

hailin0 commented Apr 18, 2024

@TaoZex

@Hisoka-X
Copy link
Member

Hisoka-X commented Jun 4, 2024

Please fix CI. Thanks

@TaoZex TaoZex requested a review from hailin0 June 17, 2024 04:32
@TaoZex TaoZex requested a review from hailin0 June 17, 2024 11:23
@hailin0
Copy link
Member

hailin0 commented Jun 17, 2024

Do you have plans to support cdc/savemode/multi-table?

@TaoZex
Copy link
Contributor Author

TaoZex commented Jun 17, 2024

Do you have plans to support cdc/savemode/multi-table?

Of course. Please assign to me.

rows = [
{
kind = INSERT
fields = [true, "2020-02-02T02:02:02", "NEW", 1, 2, 3, 4, 4.3, 5.3, 6.3]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add mores test data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@hailin0 hailin0 changed the title [Connector]Add druid sink connector [Feature][Connector] Add druid sink connector Jun 17, 2024
@TaoZex TaoZex requested a review from hailin0 June 18, 2024 07:40
hailin0
hailin0 previously approved these changes Jun 19, 2024
Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These synchronized keywords give the impression that these methods will be called concurrently, but in fact they will not.

@Hisoka-X Hisoka-X added this to the 2.3.6 milestone Jun 19, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passed.

@hailin0 hailin0 merged commit d7fa9af into apache:dev Jun 19, 2024
8 checks passed
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants