Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] update action config to support run CI on fork repo #5065

Merged
merged 1 commit into from
Jul 12, 2023
Merged

[Feature] update action config to support run CI on fork repo #5065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions .github/workflows/backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
name: Backend
on:
push:
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove below setting?

branches:
       - dev

This will cause only submit PR to dev will trigger the workflow?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove below setting?

branches:
       - dev

This will cause only submit PR to dev will trigger the workflow?

@EricJoy2048 @hailin0 @Hisoka-X @ic4y PTAL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove below setting?

branches:
       - dev

This will cause only submit PR to dev will trigger the workflow?

@EricJoy2048 @hailin0 @Hisoka-X @ic4y PTAL

@TyrantLucifer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove below setting?

branches:
       - dev

This will cause only submit PR to dev will trigger the workflow?

I think there is no problem with the dev branch, we are mainly developing in the dev branch now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we cp to release-branch, the ci will not trigger, it would be better to keep the origin rule.
Why we add the new rule "only trigger on dev"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only trigger on dev rule is added on this pr: https://github.com/apache/seatunnel/pull/4522/files.

For this pr, my purpose is enable the CI on fork repo. Then it can run CI on fork repo first to check, fix error to reduce everyone's time

branches:
- dev
pull_request:
paths-ignore:
- 'docs/**'
- '**/*.md'
Expand All @@ -32,7 +32,7 @@ concurrency:

jobs:
license-header:
if: github.repository == 'apache/seatunnel'
if: github.repository == '${{github.actor}}/seatunnel'
name: License header
runs-on: ubuntu-latest
timeout-minutes: 10
Expand All @@ -44,7 +44,7 @@ jobs:
uses: apache/skywalking-eyes@985866ce7e324454f61e22eb2db2e998db09d6f3

code-style:
if: github.repository == 'apache/seatunnel'
if: github.repository == '${{github.actor}}/seatunnel'
name: Code style
runs-on: ubuntu-latest
timeout-minutes: 10
Expand All @@ -56,7 +56,7 @@ jobs:
run: ./mvnw --batch-mode --quiet --no-snapshot-updates clean spotless:check

dead-link:
if: github.repository == 'apache/seatunnel'
if: github.repository == '${{github.actor}}/seatunnel'
name: Dead links
runs-on: ubuntu-latest
timeout-minutes: 30
Expand All @@ -69,7 +69,7 @@ jobs:
done

sanity-check:
if: github.repository == 'apache/seatunnel'
if: github.repository == '${{github.actor}}/seatunnel'
name: Sanity check results
needs: [ license-header, code-style, dead-link ]
runs-on: ubuntu-latest
Expand All @@ -83,8 +83,7 @@ jobs:

changes:
runs-on: ubuntu-latest
# To prevent error when there's no base branch
if: github.repository == 'apache/seatunnel'
if: github.repository == '${{github.actor}}/seatunnel'
timeout-minutes: 10
outputs:
api: ${{ steps.filter.outputs.api }}
Expand Down