Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map #3719

Merged
merged 8 commits into from
Jan 3, 2023
Merged

[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map #3719

merged 8 commits into from
Jan 3, 2023

Conversation

Hisoka-X
Copy link
Member

Purpose of this pull request

Check list

@Hisoka-X
[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map
d42c29f
@Hisoka-X
Merge branch 'dev' into fix_config_prefix
a503a53 
# Conflicts:
#	docs/en/connector-v2/sink/Kafka.md
#	seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkWriter.java
@Hisoka-X
[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map
e1be1b1
TaoZex
TaoZex reviewed Dec 14, 2022
View reviewed changes
Copy link
Contributor

@TaoZex TaoZex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good way for users to custom config!

docs/en/connector-v2/sink/StarRocks.md Outdated Show resolved Hide resolved
hailin0
hailin0 previously approved these changes Dec 16, 2022
View reviewed changes
@Hisoka-X @TaoZex
Update docs/en/connector-v2/sink/StarRocks.md
91e90a5 
Co-authored-by: TaoZex <45089228+TaoZex@users.noreply.github.com>
@Hisoka-X Hisoka-X closed this Dec 19, 2022
@Hisoka-X Hisoka-X reopened this Dec 19, 2022
EricJoy2048
EricJoy2048 previously approved these changes Dec 26, 2022
View reviewed changes
CalvinKirs
CalvinKirs previously approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, For incompatible field changes, is it necessary for us to detail in the change-log?

@Hisoka-X
Copy link
Member Author

BTW, For incompatible field changes, is it necessary for us to detail in the change-log?

Yes, We can add reason on next version change-log.

@Hisoka-X Hisoka-X dismissed stale reviews from CalvinKirs and EricJoy2048 via ac1e9e8 December 29, 2022 08:04
@CalvinKirs CalvinKirs merged commit ef1b8b1 into apache:dev Jan 3, 2023
@Hisoka-X Hisoka-X deleted the fix_config_prefix branch January 3, 2023 03:28
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Jan 3, 2023
@Hisoka-X @lhyundeadsoul
[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map (…
10d60f2 
…apache#3719)

* [Improve] [Connector-V2] Change Connector Custom Config Prefix To Map
lhyundeadsoul pushed a commit to lhyundeadsoul/incubator-seatunnel that referenced this pull request Jan 3, 2023
@Hisoka-X @lhyundeadsoul
[Improve] [Connector-V2] Change Connector Custom Config Prefix To Map (…
8dc576a 
…apache#3719)

* [Improve] [Connector-V2] Change Connector Custom Config Prefix To Map
@TaoZex TaoZex mentioned this pull request Jan 3, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

@TaoZex TaoZex TaoZex approved these changes

@hailin0 hailin0 hailin0 left review comments

Assignees
No one assigned
Labels
approved connectors-v2 document improve reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Hisoka-X @hailin0 @CalvinKirs @EricJoy2048 @TaoZex