-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Conenctor-V2] Add openmldb source connector #3313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an e2e use case?
OpenMldb image need change ip address that in config files. Ip can not be code name,so that use test container to write e2e is impossible and I desided to do the integration test instead of it. |
Doris was the same way. I was trying to automatically change ip address through shell script when docker was opened. |
Test container uses hostname to assign ip to container, how do I get the real ip address and change it in container? If you have good ideas to solve this problem, can you do this work or give some guides to me? |
I'm trying to do this, and I'll let you know if I get any good news. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please implement TableSourceFactory
.../src/main/java/org/apache/seatunnel/connectors/seatunnel/openmldb/source/OpenMldbSource.java
Show resolved
Hide resolved
a37f0b9
to
6649120
Compare
71d7d46
to
7052211
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, It looks good overall
Purpose of this pull request
Add openmldb source connector #3018
Check list
New License Guide