Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Conenctor-V2] Add openmldb source connector #3313

Merged
merged 15 commits into from
Nov 27, 2022

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

Add openmldb source connector #3018

Check list

@TyrantLucifer
Copy link
Member Author

openmldb only support these data types:

image

spark integration test:

image

flink integration test:

image

image

Copy link
Member

@ashulin ashulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an e2e use case?

@TyrantLucifer
Copy link
Member Author

Can you add an e2e use case?

OpenMldb image need change ip address that in config files. Ip can not be code name,so that use test container to write e2e is impossible and I desided to do the integration test instead of it.

@TaoZex
Copy link
Contributor

TaoZex commented Nov 7, 2022

Can you add an e2e use case?

OpenMldb image need change ip address that in config files. Ip can not be code name,so that use test container to write e2e is impossible and I desided to do the integration test instead of it.

Doris was the same way. I was trying to automatically change ip address through shell script when docker was opened.

@TyrantLucifer
Copy link
Member Author

TyrantLucifer commented Nov 7, 2022

Can you add an e2e use case?

OpenMldb image need change ip address that in config files. Ip can not be code name,so that use test container to write e2e is impossible and I desided to do the integration test instead of it.

Doris was the same way. I was trying to automatically change ip address through shell script when docker was opened.

Test container uses hostname to assign ip to container, how do I get the real ip address and change it in container? If you have good ideas to solve this problem, can you do this work or give some guides to me?

@TaoZex
Copy link
Contributor

TaoZex commented Nov 7, 2022

Can you add an e2e use case?

OpenMldb image need change ip address that in config files. Ip can not be code name,so that use test container to write e2e is impossible and I desided to do the integration test instead of it.

Doris was the same way. I was trying to automatically change ip address through shell script when docker was opened.

Test container uses hostname to assign ip to container, how do I get the real ip address and change it in container? If you have good ideas to solve this problem, can you do this work or give some guides to me?

I'm trying to do this, and I'll let you know if I get any good news.

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement TableSourceFactory

Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It looks good overall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants