Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][Connector-V2][File] Support parse field from file path #2985

Merged
merged 9 commits into from
Oct 15, 2022

Conversation

TyrantLucifer
Copy link
Member

Purpose of this pull request

fix #2871

Check list

@TyrantLucifer TyrantLucifer changed the title [Improve][Connector-V2] Support parse field from file path [WIP][Improve][Connector-V2] Support parse field from file path Oct 5, 2022
@TyrantLucifer TyrantLucifer changed the title [WIP][Improve][Connector-V2] Support parse field from file path [Improve][Connector-V2][File] Support parse field from file path Oct 11, 2022
@TyrantLucifer TyrantLucifer marked this pull request as ready for review October 11, 2022 12:11
CalvinKirs
CalvinKirs previously approved these changes Oct 12, 2022
Copy link
Member

@CalvinKirs CalvinKirs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, It would be nice to have some test code

Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @CalvinKirs PTAL

@CalvinKirs CalvinKirs merged commit 0bc1208 into apache:dev Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Connector-V2] Hive Source Connector don't add the partition fields and values in to data
3 participants