[Feature][Connector] New SeaTunnel API Connectors #1946 Add Druid Source&Sink #2651
Conversation
|
THX，I deal with connector-v2 e2e-testcase |
|
@hailin0 |
|
|
||
| ```hocon | ||
| DruidSource { | ||
| url = "jdbc:avatica:remote:url=http://localhost:8082/druid/v2/sql/avatica/" |
There was a problem hiding this comment.
- jdbc的协议有http吗？
- 请使用说明对url进行标注， http://{IP or domain}:[port]/
- 字段作用与说明请写上
| statement = connection.prepareStatement(quarySQL, ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY); | ||
| return statement.getMetaData(); | ||
| } catch (SQLException se) { | ||
| throw new SQLException("ResultSetMetaData() failed." + se.getMessage(), se); |
There was a problem hiding this comment.
与openInputFormat的异常不一样，不应该使用一样的异常吗？
| quarySQL = getSQL(); | ||
| connection = DriverManager.getConnection(druidSourceOptions.getURL()); | ||
| statement = connection.prepareStatement(quarySQL, ResultSet.TYPE_FORWARD_ONLY, ResultSet.CONCUR_READ_ONLY); | ||
| return statement.getMetaData(); |
There was a problem hiding this comment.
是否可以把 60,62独立一个方法。因为与69，70一样。或则与openInputFormat方法进行合并下
| } | ||
|
|
||
| public void closeInputFormat() { | ||
| try { |
There was a problem hiding this comment.
是否可以使用try-with解决方案，可以提前释放statement，connent
| columns = String.join(",", druidSourceOptions.getColumns()); | ||
| } | ||
|
|
||
| String sql = String.format(QUERY_TEMPLATE, columns, dataSource); |
| import java.io.Serializable; | ||
|
|
||
| public class DruidSourceConfig { | ||
| public static final String URL = "url"; |
| @Data | ||
| @AllArgsConstructor | ||
| public class DruidSourceOptions implements Serializable { | ||
| private String URL; |
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| public class DruidTypeMapper { |
| @AutoService(SeaTunnelSink.class) | ||
| public class DruidSink extends AbstractSimpleSink<SeaTunnelRow, Void> { | ||
|
|
||
| private Config config; |
| this.datasource = pluginConfig.getString(DruidSinkConfig.DATASOURCE); | ||
| this.columns = pluginConfig.getStringList(DruidSinkConfig.COLUMNS); | ||
| this.timestampColumn = pluginConfig.hasPath(DruidSinkConfig.TIMESTAMP_COLUMN) ? pluginConfig.getString(DruidSinkConfig.TIMESTAMP_COLUMN) : null; | ||
| this.timestampFormat = pluginConfig.hasPath(DruidSinkConfig.TIMESTAMP_FORMAT) ? pluginConfig.getString(DruidSinkConfig.TIMESTAMP_FORMAT) : null; |
There was a problem hiding this comment.
是否可以加强Config对象， pluginConfig.getString(DruidSinkConfig.TIMESTAMP_COLUMN,null);
这样谁用都简单
e2e should be submitted with the feature, use e2e validation feature running result instead of code review reference |
|
@hailin0 ok thx，What is your wechat account in the group and ask you some questions |
… Source&Sink #2651 add Spark Example demo and Checkstyle code
|
Hi, @guanboo Please resolve conflicts. |
|
done #2937 |
… Source&Sink
Purpose of this pull request
Check list
New License Guide