[ISSUE #30]Supports batch resending and batch exporting dlq messages. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vongosling
approved these changes
Nov 2, 2021
StyleTang
reviewed
Nov 2, 2021
| * limitations under the License. | ||
| */ | ||
| package org.apache.rocketmq.dashboard.model; | ||
|
|
There was a problem hiding this comment.
getters/setters can be generated by @Data
| dlqMessage.getClientId()); | ||
| consumeMessageDirectlyResults.add(consumeMessageDirectlyResult); | ||
| } | ||
| return consumeMessageDirectlyResults.get(0); |
There was a problem hiding this comment.
Batch resend the message but just get the first result. If we do a batch operation, we should get all the results.
| DlqMessageExcelModel excelModel = new DlqMessageExcelModel(messageExt); | ||
| dlqMessageExcelModelList.add(excelModel); | ||
| } catch (Exception e) { | ||
| log.error("Failed to query message by Id:{}", dlqMessage.getMsgId()); |
There was a problem hiding this comment.
Maybe returning the failed record with message-id and fail reason is better than just ignoring the exception.
DlqMessageExcelModel excelModel = new DlqMessageExcelModel();
excelModel.setMessageId(messageId);
excelModel.setException(error);
dlqMessageExcelModelList.add(excelModel);
StyleTang
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
#30
Send and export dead-letter messages in batches.
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.