Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1.0 rocketmq version update #155

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Conversation

Abhijeetmishr
Copy link
Contributor

What is the purpose of the change

rocketmq version update to 5.1.0

Todo's

  • MQAdminExtImpl have some unimplemented methods.

@Abhijeetmishr
Copy link
Contributor Author

@Oliverwqcwrw Please check this

@Abhijeetmishr
Copy link
Contributor Author

@Oliverwqcwrw Please check this

@Oliverwqcwrw @zhangjidi2016 please let me know if any futher change is needed when available.

Copy link
Member

@Oliverwqcwrw Oliverwqcwrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Abhijeetmishr
Copy link
Contributor Author

@Oliverwqcwrw original issue is still pending we have to fix it asap and that depends on this PR.
If this will be reviewed and merged then I can start working on others too.

@Oliverwqcwrw
Copy link
Member

Let's wait patiently for other reviewer's opinions

@Oliverwqcwrw Oliverwqcwrw merged commit a25ccd6 into apache:master Apr 7, 2023
@Oliverwqcwrw
Copy link
Member

@Abhijeetmishr ,Thanks for your contribution :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants