Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message track query enhancement #19

Closed
zhangjidi2016 opened this issue Sep 9, 2021 · 3 comments · Fixed by #21
Closed

Message track query enhancement #19

zhangjidi2016 opened this issue Sep 9, 2021 · 3 comments · Fixed by #21
Labels
enhancement New feature or request
Milestone
1.0.0

Comments

@zhangjidi2016
Copy link
Contributor

Currently, system topic (RMQ_SYS_TRACE_TOPIC) or message track defined in configuration files are used by default for message track query on the console. But now, users can specify specific topic to save message track information when sending and receiving messages on the client. If so, The console cannot query this message track information.

image

Can we select the previously specified message track topic before the user queries the message track information, like this? @StyleTang @vongosling

image
@zongtanghu zongtanghu added the enhancement New feature or request label Sep 9, 2021
@StyleTang
Copy link
Member

I think choosing a track message topic manually is not a good user experience.
Users rarely modify msgTrackTopic, we have a rocketmq.config.msgTrackTopicName config to use a specific message track topic.

@zhangjidi2016
Copy link
Contributor Author

Yes, msgTrackTopic rarely set, but if different users on the client side using different msgTrackTopic In the same cluster, and rocketmq. config. msgTrackTopicName in rocketmq-dashboard can be set only one. I think we should consider this situation.

@StyleTang
Copy link
Member

I get it, you are right, It is necessary to let users choose the msgTrackTopic by themselves.

zhangjidi2016 pushed a commit to zhangjidi2016/rocketmq-dashboard that referenced this issue Sep 10, 2021
[ISSUE apache#19]Message track query enhancement
6244f26
@zhangjidi2016 zhangjidi2016 mentioned this issue Sep 10, 2021
Merged
6 tasks
@vongosling vongosling linked a pull request Sep 15, 2021 that will close this issue
[ISSUE #19]Message track query enhancement #21
Merged
6 tasks
StyleTang pushed a commit that referenced this issue Sep 23, 2021
@zhangjidi2016
[ISSUE #19]Message track query enhancement (#21)
58336d9 
* [ISSUE #19]Message track query enhancement

* traceTopic can be null and system Topic is used by default

* add unit test

* select messageTrack topic in messageTrace page

Co-authored-by: zhangjidi <zhangjidi@cmss.chinamobile.com>
@StyleTang StyleTang added this to the 1.0.0 milestone Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #19]Message track query enhancement zhangjidi2016/rocketmq-dashboard
3 participants
@zongtanghu @StyleTang @zhangjidi2016