Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix some cpp client bug #928

Closed
3 tasks done
lizhimins opened this issue Jan 20, 2025 · 0 comments · Fixed by #929, #931 or #932
Closed
3 tasks done

[Bug] Fix some cpp client bug #928

lizhimins opened this issue Jan 20, 2025 · 0 comments · Fixed by #929, #931 or #932
Labels
type/bug Something isn't working

Comments

@lizhimins
Copy link
Member

lizhimins commented Jan 20, 2025

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.
  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Programming Language of the Client

CPP

Runtime Platform Environment

Linux 5.1

RocketMQ Version of the Client/Server

Current master branch

Run or Compiler Version

GCC 10.2

Describe the Bug

Part 1:

  1. When the sending is successful, the result should return information such as the message ID.
  2. Remove unnecessary header file references and standardize the log structure.
  3. The protocol used by the Simple Consumer does not match the RocketMQ gRPC protocol.

Part 2:

  1. Fix the issue with the shutdown state machine that prevented the client from shutting down
  2. Fix the issue where the simple consumer would be periodically disconnected by the server due to a lack of heartbeats
  3. Fix the incorrect return value in the simple consumer receive

中文版:

  1. 修复 shutdown 状态机错误导致无法关闭客户端的问题
  2. 修复 simple consumer 没心跳导致定时被服务端踢下线的问题
  3. 修复 consumer receive 返回值错误处理导致链接断开的问题

特别的:

MacOS 13 和 14 下如果使用 Clang 和 bazel,因为生成的 gRPC 代码里面包含了 depreacted asio 实现,需要修改下

Steps to Reproduce

todo

What Did You Expect to See?

todo

What Did You See Instead?

todo

Additional Context

No response

@lizhimins lizhimins added the type/bug Something isn't working label Jan 20, 2025
@lizhimins lizhimins changed the title [Bug] Fix some cpp clinet bug [Bug] Fix some cpp client bug Jan 20, 2025
lizhimins added a commit to lizhimins/rocketmq-clients that referenced this issue Jan 21, 2025
lizhimins added a commit to lizhimins/rocketmq-clients that referenced this issue Jan 21, 2025
lizhimins added a commit to lizhimins/rocketmq-clients that referenced this issue Jan 22, 2025
lizhimins added a commit to lizhimins/rocketmq-clients that referenced this issue Jan 22, 2025
lizhimins added a commit to lizhimins/rocketmq-clients that referenced this issue Jan 23, 2025
lizhimins added a commit to lizhimins/rocketmq-clients that referenced this issue Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment