feat(jsoncpp): update jsoncpp to 0.10.7 in order to fix build error by gcc7+ #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 57.7% 57.69% -0.01%
==========================================
Files 182 182
Lines 11651 11652 +1
==========================================
Hits 6723 6723
- Misses 4928 4929 +1
Continue to review full report at Codecov.
|
|
close #255 |
vongosling
reviewed
Feb 24, 2020
README.md
Outdated
| @@ -33,9 +33,9 @@ RocketMQ-Client-CPP is the C/C++ client of Apache RocketMQ, a distributed messag | |||
| - bzip2-devel 1.0.6: boost depend it | |||
| - zlib-devel | |||
|
|
|||
| The **build.sh** script will automatically download and build the dependency libraries including libevent, json and boost. It will save libraries under rocketmq-client-cpp folder, and then build both static and shared libraries for rocketmq-client. If the dependent libraries are built failed, you could try to build it manually with sources [libevent 2.0.22](https://github.com/libevent/libevent/archive/release-2.0.22-stable.zip "lib event 2.0.22"), [jsoncpp 0.10.6](https://github.com/open-source-parsers/jsoncpp/archive/0.10.6.zip "jsoncpp 0.10.6"), [boost 1.58.0](http://sourceforge.net/projects/boost/files/boost/1.58.0/boost_1_58_0.tar.gz "boost 1.58.0") | |||
| The **build.sh** script will automatically download and build the dependency libraries including libevent, json and boost. It will save libraries under rocketmq-client-cpp folder, and then build both static and shared libraries for rocketmq-client. If the dependent libraries are built failed, you could try to build it manually with sources [libevent 2.0.22](https://github.com/libevent/libevent/archive/release-2.0.22-stable.zip "lib event 2.0.22"), [jsoncpp 0.10.7](https://github.com/open-source-parsers/jsoncpp/archive/0.10.7.zip "jsoncpp 0.10.6"), [boost 1.58.0](http://sourceforge.net/projects/boost/files/boost/1.58.0/boost_1_58_0.tar.gz "boost 1.58.0") | |||
There was a problem hiding this comment.
There is still jsoncpp 0.10.6 in your comment. Whats' more, I could find the release note about 0.10.7 and figure out does it make an change for its own dependency. At last, Do we have the upgrade plan for jsoncpp 1.x.y?
vongosling
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[ISSUE #255 ]
feat(jsoncpp): update jsoncpp to 0.10.7 in order to fix build error by gcc7+
Brief changelog