Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add timer to clean off line broker and test case. #222

Merged
merged 4 commits into from
Jan 10, 2020

Conversation

ShannonDing
Copy link
Member

What is the purpose of the change

feat(client): add timer to clean off line broker and test case.

Brief changelog

feat(client): add timer to clean off line broker and test case.

@ShannonDing ShannonDing added the enhancement New feature or request label Jan 9, 2020
@ShannonDing ShannonDing added this to the 1.2.5 milestone Jan 9, 2020
@ShannonDing ShannonDing requested a review from jonnxu January 9, 2020 09:51
@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #222 into master will increase coverage by 2.28%.
The diff coverage is 72.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   45.53%   47.82%   +2.28%     
==========================================
  Files         171      173       +2     
  Lines       10243    10441     +198     
==========================================
+ Hits         4664     4993     +329     
+ Misses       5579     5448     -131
Impacted Files Coverage Δ
src/MQClientManager.cpp 100% <ø> (ø) ⬆️
src/MQClientAPIImpl.cpp 16.14% <0%> (+13.39%) ⬆️
src/MQClientFactory.cpp 18.45% <10.34%> (+12%) ⬆️
test/src/MQClientFactoryTest.cpp 100% <100%> (ø)
test/src/MQClientAPIImpTest.cpp 98.11% <98.11%> (ø)
src/common/MQClient.cpp 38.61% <0%> (-0.39%) ⬇️
src/producer/DefaultMQProducer.cpp 5.47% <0%> (-0.02%) ⬇️
src/consumer/OffsetStore.cpp 0% <0%> (ø) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2faaa1f...720d45a. Read the comment docs.

@ShannonDing ShannonDing merged commit b5b3b35 into apache:master Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants