Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost build64 on windows #167

Merged
merged 3 commits into from
Aug 8, 2019
Merged

boost build64 on windows #167

merged 3 commits into from
Aug 8, 2019

Conversation

doodoocoder
Copy link
Contributor

@doodoocoder doodoocoder commented Jul 19, 2019

the command should be this: .\b2 -j8 --with-serialization --with-atomic --with-log --with-locale --with-iostreams --with-system --with-regex --with-thread --with-date_time --with-chrono --with-filesystem --build-type=complete address-model=64 ,

not that: bjam.exe address-model=64 --with-serialization --with-atomic --with-log --with-locale --with-iostreams --with-system --with-regex --with-thread --with-date_time --with-chrono --with-filesystem link=static threading=multi variant=release runtime-link=shared
or the vs2015 will prompt the error can not find libboost_system-vc140-mt-gd-1_58.lib

What is the purpose of the change

XXXXX

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

the command should be  this: .\b2 -j8 --with-serialization --with-atomic --with-log --with-locale --with-iostreams --with-system --with-regex --with-thread --with-date_time --with-chrono --with-filesystem --build-type=complete address-model=64 ,

not that: bjam.exe address-model=64 --with-serialization --with-atomic --with-log --with-locale --with-iostreams --with-system --with-regex --with-thread --with-date_time --with-chrono --with-filesystem  link=static  threading=multi variant=release runtime-link=shared
or the vs2015 will prompt the error can not find libboost_system-vc140-mt-gd-1_58.lib
use different command for x86 or x64 respectively
use different command for x86 or x64 respectively
@@ -61,8 +61,12 @@ If your host is not available to internet to download the four library source fi

[jsoncpp-0.10.6](https://codeload.github.com/jsj020122/jsoncpp-0.10.6/zip/master "jsoncpp-0.10.6") Extract to $(rocketmq-client-cpp root dir)/thirdparty/jsoncpp-0.10.6

And then run following command to build rocketmq-client:
And then run following command to build x86 rocketmq-client:

win32_build.bat build

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the name "boost build64 on windows" to "[ISSUE#166] Add build64 on windows "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you say ,I change the tittle of [ISSUE#166] to Add build64 on windows

@jonnxu
Copy link
Contributor

jonnxu commented Jul 20, 2019

thank you for your pr @doodoocoder , if you can review and check this pr @hugoasdf

@doodoocoder
Copy link
Contributor Author

thank you for your pr @doodoocoder , if you can review and check this pr @hugoasdf
ok,I will test this project completely.

@@ -85,7 +85,7 @@ set ZLIB_INCLUDE="%cd%\zlib-1.2.3-src\src\zlib\1.2.3\zlib-1.2.3\"
::cd boost_1_58_0
call bootstrap.bat
@echo build start.....
bjam.exe address-model=64 --with-serialization --with-atomic --with-log --with-locale --with-iostreams --with-system --with-regex --with-thread --with-date_time --with-chrono --with-filesystem link=static threading=multi variant=release runtime-link=shared
.\b2 -j8 --with-serialization --with-atomic --with-log --with-locale --with-iostreams --with-system --with-regex --with-thread --with-date_time --with-chrono --with-filesystem --build-type=complete address-model=64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, here "bjam.exe address-model=64" change to .\b2 -j8 is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course it is correct,I test it very carefully. address-model=64 is in the last of .b2 command.

@ShannonDing ShannonDing added this to the 1.2.3 milestone Aug 8, 2019
@ShannonDing ShannonDing added the enhancement New feature or request label Aug 8, 2019
@ShannonDing ShannonDing merged commit f8e2faf into apache:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants