Fixed reg test for cross-region S3 calls #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-maynard
approved these changes
Feb 12, 2025
Comment on lines
-45
to
-47
| curl -H "Authorization: Bearer ${SPARK_BEARER_TOKEN}" -H 'Accept: application/json' -H 'Content-Type: application/json' \ | ||
| "http://${POLARIS_HOST:-localhost}:8181/api/catalog/v1/config?warehouse=spark_sql_s3_cross_region_catalog" | ||
| echo |
There was a problem hiding this comment.
It looks like this is being removed because the output will change depending on AWS_REGION_FOR_CROSS_REGION_TEST, is that right?
Rather than removing it, I wonder if we could do some jq magic to make it env-variable-agnostic.
Anyway, it's not an issue to just remove it imo.
There was a problem hiding this comment.
Yeah, it would be a useful feature to add, but for right now, i just want to make the tests pass :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regression test for cross-region S3 calls has been broken for quite a long time, but it never runs in CI anymore, so no one noticed. This updates the catalog creation to take in environment variables, pass in the correct region parameters, and fixes whitespace issues in the output diff.