Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Caffeine's Expiry.creating for StorageCredentialCache #1142

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use Caffeine's Expiry.creating for StorageCredentialCache #1142

wants to merge 2 commits into from
+11 −34

Conversation

smaheshwar-pltr
Copy link
Contributor

@smaheshwar-pltr smaheshwar-pltr commented Mar 10, 2025 •
edited
Loading

The StorageCredentialCache currently uses a custom Expiry. I think that this works correctly.

IMHO using a built-in one that Caffeine provides, like Expiry.writing reads better - this is what this PR proposes.

@smaheshwar-pltr smaheshwar-pltr changed the title Update storage credential cache expiration on value replacement Use Caffeine's Expiry.writing for StorageCredentialCache Mar 10, 2025
@smaheshwar-pltr smaheshwar-pltr changed the title Use Caffeine's Expiry.writing for StorageCredentialCache Use Caffeine's Expiry.writing for StorageCredentialCache Mar 10, 2025
@smaheshwar-pltr smaheshwar-pltr marked this pull request as ready for review March 10, 2025 13:38
@smaheshwar-pltr smaheshwar-pltr changed the title Use Caffeine's Expiry.writing for StorageCredentialCache Use Caffeine's Expiry.creating for StorageCredentialCache Mar 12, 2025
dimas-b
dimas-b approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @smaheshwar-pltr !

This is a nice code clarification 👍

@dimas-b
Copy link
Contributor

dimas-b commented Mar 12, 2025

@collado-mike @eric-maynard WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimas-b dimas-b dimas-b approved these changes

@adutra adutra Awaiting requested review from adutra adutra is a code owner

@ashvina ashvina Awaiting requested review from ashvina ashvina is a code owner

@dennishuo dennishuo Awaiting requested review from dennishuo dennishuo is a code owner

@eric-maynard eric-maynard Awaiting requested review from eric-maynard eric-maynard is a code owner

@jackye1995 jackye1995 Awaiting requested review from jackye1995 jackye1995 is a code owner

@jbonofre jbonofre Awaiting requested review from jbonofre jbonofre is a code owner

@vvcephei vvcephei Awaiting requested review from vvcephei vvcephei is a code owner

@collado-mike collado-mike Awaiting requested review from collado-mike collado-mike is a code owner

@snazy snazy Awaiting requested review from snazy snazy is a code owner

@RussellSpitzer RussellSpitzer Awaiting requested review from RussellSpitzer RussellSpitzer is a code owner

@takidau takidau Awaiting requested review from takidau takidau is a code owner

@MonkeyCanCode MonkeyCanCode Awaiting requested review from MonkeyCanCode MonkeyCanCode is a code owner

@flyrain flyrain Awaiting requested review from flyrain flyrain is a code owner

@ebyhr ebyhr Awaiting requested review from ebyhr ebyhr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smaheshwar-pltr @dimas-b