Remove all tightly coupled EntityCache dependencies in the main persistence stack #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stence stack Remove the EntityCacheEntry wrapper since the timestamp fields were never used anyways; instead the underlying Caffeine cache transparently handles access times, and the types of entries we cache are simply the existing ResolvedPolarisEntity. Remove interactions of business logic with explicit "cache entries", instead operating on ResolvedPolarisEntity. Fix the equals()/hashCode() behavior of PolarisEntity to be compatible with PolarisBaseEntity as intended. Improve code comments to explain the (current) relationship between PolarisEntity and PolarisBaseEntity, and clarify the behaviors in Resolver.java. Fully remove the PolarisRemoteCache interface and its methods. Add different methods that aren't cache-specific instead.
…erize ResolverTest
jbonofre
approved these changes
Feb 24, 2025
| * Currently, code that intends to operate directly on a PolarisBaseEntity may not adhere to | ||
| * immutability semantics, and may modify the entity in-place. | ||
| * | ||
| * <p>TODO: Combine this fully into PolarisBaseEntity, refactor all callsites to use strict |
There was a problem hiding this comment.
It sounds reasonnable to me to only have PolarisBaseEntity. PolarisEntity is a bit confusing at first glance.
eric-maynard
approved these changes
Feb 24, 2025
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Mar 6, 2025
Following up on apache#1055, this refactoring does not remove `EntityCache`, but allows it to be `null` in principle, should a particular MetaStoreManagerFactory implementation choose not to use an `EntityCache`. * Remove bean producer for `EntityCache` (beans cannot be `null`). * Harmonize all `PolarisEntityManager` producers (explicit and CDI) to go through `RealmEntityManagerFactory` (tangential to the cache being null, but related).
dimas-b
added a commit
that referenced
this pull request
Mar 8, 2025
Following up on #1055, this refactoring does not remove `EntityCache`, but allows it to be `null` in principle, should a particular MetaStoreManagerFactory implementation choose not to use an `EntityCache`. * Remove bean producer for `EntityCache` (beans cannot be `null`). * Harmonize all `PolarisEntityManager` producers (explicit and CDI) to go through `RealmEntityManagerFactory` (tangential to the cache being null, but related).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the EntityCacheEntry wrapper since the timestamp fields were never used anyways; instead the underlying Caffeine cache transparently handles access times, and the types of entries we cache are simply the existing ResolvedPolarisEntity.
Remove interactions of business logic with explicit "cache entries", instead operating on ResolvedPolarisEntity. Fix the equals()/hashCode() behavior of PolarisEntity to be compatible with PolarisBaseEntity as intended.
Improve code comments to explain the (current) relationship between PolarisEntity and PolarisBaseEntity, and clarify the behaviors in Resolver.java.
Fully remove the PolarisRemoteCache interface and its methods. Add different methods that aren't cache-specific instead.
Add support for constructing Resolver with null EntityCache to skip all cache interactions entirely.