Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade swagger-ui version to 3.23.11 for CVE-2019-17495 #7902

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Dec 14, 2021

Description

Upgrade swagger-ui version to 3.23.11 for CVE-2019-17495

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

Documentation

@xiangfu0 xiangfu0 linked an issue Dec 14, 2021 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #7902 (55a836a) into master (9127286) will decrease coverage by 6.30%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7902      +/-   ##
============================================
- Coverage     71.25%   64.94%   -6.31%     
- Complexity     4087     4088       +1     
============================================
  Files          1589     1544      -45     
  Lines         82131    80260    -1871     
  Branches      12271    12068     -203     
============================================
- Hits          58520    52124    -6396     
- Misses        19643    24413    +4770     
+ Partials       3968     3723     -245     
Flag Coverage Δ
integration1 ?
integration2 ?
unittests1 68.32% <ø> (+<0.01%) ⬆️
unittests2 14.38% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...apache/pinot/minion/MinionAdminApiApplication.java 0.00% <0.00%> (-91.67%) ⬇️
...pinot/broker/broker/BrokerAdminApiApplication.java 92.68% <100.00%> (ø)
.../controller/api/ControllerAdminApiApplication.java 92.45% <100.00%> (ø)
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/SegmentReloadMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/core/data/manager/realtime/TimerService.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 361 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9127286...55a836a. Read the comment docs.

@xiangfu0 xiangfu0 merged commit 50e1613 into apache:master Dec 14, 2021
@xiangfu0 xiangfu0 deleted the fix-swagger-ui-vulnerabilities branch December 14, 2021 23:24
@xiangfu0 xiangfu0 changed the title Upgrade swagger-ui version for CVE-2019-17495 Upgrade swagger-ui version to 3.23.11 for CVE-2019-17495 Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security vulnerability while provisioning pinot version 0.9.1
3 participants