Move Parquet related classes to the new package #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new package: pinot-parquet for all Parquet related classes Remove the dependency of parquet-avro from pinot-common
This was referenced Apr 4, 2019
snleee
approved these changes
Apr 4, 2019
| throws IOException { | ||
| Path dataFsPath = new Path(fileName); | ||
| return AvroParquetReader.<GenericRecord>builder(dataFsPath).disableCompatibility().withDataModel(GenericData.get()) | ||
| //noinspection unchecked |
There was a problem hiding this comment.
IDE can read this and suppress the warning for this cast.
| recordReaderPath, fileFormat.toString()); | ||
| // NOTE: we currently have default file format set to AVRO inside segment generator config, do not want to break | ||
| // this behavior for clients. | ||
| LOGGER |
There was a problem hiding this comment.
Previous format looks better to me :)
There was a problem hiding this comment.
I agree, but just follow the auto-format...
| @@ -101,8 +101,7 @@ public void setup(Context context) | |||
| if (readerConfigFile != null) { | |||
| _readerConfigFile = new Path(readerConfigFile); | |||
| } | |||
|
|
|||
| _recordReaderPath = _jobConf.get(JobConfigConstants.RECORD_READER_PATH, null); | |||
| _recordReaderPath = _jobConf.get(JobConfigConstants.RECORD_READER_PATH); | |||
There was a problem hiding this comment.
RECORD_READER_CLASS_NAME seems to be more correct name... But, I guess that we are already using this config?
There was a problem hiding this comment.
Yes, so cannot change it lol
|
TODO: Let's add the documentation on adding a new record reader and link orc/parquet prs as examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new package: pinot-parquet for all Parquet related classes
Remove the dependency of parquet-avro from pinot-common