Address comment

apache · Mar 4, 2019 · 5854f5e · 5854f5e
1 parent 7932f09
commit 5854f5e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/readers/AvroRecordReader.java b/pinot-core/src/main/java/org/apache/pinot/core/data/readers/AvroRecordReader.java
@@ -64,7 +64,7 @@ private void validateSchema() {
     org.apache.avro.Schema avroSchema = _avroReader.getSchema();
     for (FieldSpec fieldSpec : _fieldSpecs) {
       String fieldName = fieldSpec.getName();
-      Field avroField = avroSchema.getField(fieldSpec.getName());
+      Field avroField = avroSchema.getField(fieldName);
       if (avroField == null) {
         LOGGER.warn("Pinot field: {} does not exist in Avro Schema", fieldName);
       } else {

diff --git a/pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReader.java b/pinot-core/src/main/java/org/apache/pinot/core/data/readers/RecordReader.java
@@ -27,6 +27,8 @@
 /**
  * The <code>RecordReader</code> interface is used to read records from various file formats into {@link GenericRow}s.
  * Pinot segments will be generated from {@link GenericRow}s.
+ * <p>NOTE: for time column, record reader should be able to read both incoming and outgoing time (see
+ * {@link RecordReaderUtils#extractFieldSpecs(Schema)} for details).
  */
 public interface RecordReader extends Closeable {