Add method to merge PDF from InputStream source #198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new `addSource` method that accepts an `InputStream` as a parameter, enabling merging of PDFs directly from streams keeping the developer from having to understand the RandomAccessRead interfaces and use a common way of accessing file data.
aaronhagopian
commented
Dec 19, 2024
| @@ -16,10 +16,7 @@ | |||
| */ | |||
| package org.apache.pdfbox.multipdf; | |||
|
|
|||
| import java.io.File; | |||
There was a problem hiding this comment.
Just realizing this now, intellij did that automatically
|
I'd prefer to improve the javadoc. Also for |
|
I fully support @THausherr. We are using the RandomAccessRead interfaces to give the user maximum flexibility w.r.t. the used access method and possible optimization |
asfgit
pushed a commit
that referenced
this pull request
Dec 22, 2024
git-svn-id: https://svn.apache.org/repos/asf/pdfbox/branches/3.0@1922630 13f79535-47bb-0310-9956-ffa450edef68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new
addSourcemethod that accepts anInputStreamas a parameter, enabling merging of PDFs directly from streams keeping the developer from having to understand the RandomAccessRead interfaces and use a common way of accessing file data.Ideally this is merged with the 3.0 branch as well.