Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to merge PDF from InputStream source #198

Closed
wants to merge 1 commit into from

Conversation

aaronhagopian
Copy link

Introduced a new addSource method that accepts an InputStream as a parameter, enabling merging of PDFs directly from streams keeping the developer from having to understand the RandomAccessRead interfaces and use a common way of accessing file data.

Ideally this is merged with the 3.0 branch as well.

Introduced a new `addSource` method that accepts an `InputStream` as a parameter, enabling merging of PDFs directly from streams keeping the developer from having to understand the RandomAccessRead interfaces and use a common way of accessing file data.
@@ -16,10 +16,7 @@
*/
package org.apache.pdfbox.multipdf;

import java.io.File;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realizing this now, intellij did that automatically

@THausherr
Copy link
Contributor

I'd prefer to improve the javadoc. Also for Loader.loadPDF() which has the same problem.

@lehmi
Copy link
Contributor

lehmi commented Dec 21, 2024

I fully support @THausherr. We are using the RandomAccessRead interfaces to give the user maximum flexibility w.r.t. the used access method and possible optimization

asfgit pushed a commit that referenced this pull request Dec 22, 2024
@asfgit asfgit closed this in 703136e Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants