Add test data for RLE with bit_width == 0

[don4get]

Data to reproduce apache/arrow#43605.

It is used in this PR to test proper behavior:
apache/arrow#43607

[pitrou]

Naming isn't terrific as it doesn't say which GH repo this is in. Perhaps ARROW-GH-43605.parquet?

[don4get]

I agree, it is done.

[pitrou]

Thanks a lot @don4get

[pitrou]

@mapleFU Does this look ok to you?

[mapleFU]

Sorry I just back home I guess we can use same file as previous testing, let me read and check it

[mapleFU]

Personally I think we should describe more about why this causing crashed, like footer corrupt, page header metadata, invalid content like page size less than metadata described, less column chunk than in metadata description etc. We have lots of "corruput file", but the reason would be differ

[don4get]

Can you give me some help to know which part of the file is corrupted? I am not expert enough to know why the file is corrupt. I only know it is generated with a specific version of polars, as described in this PR: apache/arrow#43607 (comment)
Latest version of polars does not cause the issue anymore.

[mapleFU]

Wait a minute, I'll test this on my local pc

[mapleFU]

Emm I don't know, arrow-c++ can read this file, emm...

[don4get]

If arrow-cpp manages to open it is nice, arrow-go crashed with this before related PR on arrow. Should I move this into valid data folder then?

[pitrou]

The criterion should be: is it a valid Parquet file or not?

[pitrou]

If it's a valid Parquet file and the issue was a bug in Arrow Go preventing to read it, then it should go in data. If it's an invalid Parquet file and the issue was that Arrow Go crashed instead of reporting a regular error, then it should go in bad_data.

[mapleFU]

I'll check this later

[mapleFU]

See: #57 (comment)

Dictionary Rle page with RLE encoding bit-width is 0.

[mapleFU]

I finally catch this. This file has zero-sized dictionary bit-width. With diff:

diff --git a/cpp/src/arrow/util/bit_stream_utils_internal.h b/cpp/src/arrow/util/bit_stream_utils_internal.h
index 811694e43..176d4b1d9 100644
--- a/cpp/src/arrow/util/bit_stream_utils_internal.h
+++ b/cpp/src/arrow/util/bit_stream_utils_internal.h
@@ -22,6 +22,7 @@
 #include <algorithm>
 #include <cstdint>
 #include <cstring>
+#include <iostream>
 
 #include "arrow/util/bit_util.h"
 #include "arrow/util/bpacking.h"
@@ -312,6 +313,7 @@ inline bool BitReader::GetValue(int num_bits, T* v) {
 
 template <typename T>
 inline int BitReader::GetBatch(int num_bits, T* v, int batch_size) {
+  std::cout << "Unpack:" << num_bits << ", batch-size:" << batch_size << '\n';
   DCHECK(buffer_ != NULL);
   DCHECK_LE(num_bits, static_cast<int>(sizeof(T) * 8)) << "num_bits: " << num_bits;
 
diff --git a/cpp/src/parquet/encoding.cc b/cpp/src/parquet/encoding.cc
index 16a1e2492..b76ca1b2d 100644
--- a/cpp/src/parquet/encoding.cc
+++ b/cpp/src/parquet/encoding.cc
@@ -1626,6 +1626,7 @@ class DictDecoderImpl : public DecoderImpl, virtual public DictDecoder<Type> {
       throw ParquetException("Invalid or corrupted bit_width " +
                              std::to_string(bit_width) + ". Maximum allowed is 32.");
     }
+    std::cout << "Dictionary bit-width: " << int(bit_width) << '\n';
     idx_decoder_ = ::arrow::util::RleDecoder(++data, --len, bit_width);
   }

The dictionary bit-width is 0 here in the output.

[mapleFU]

I'll merge this first, but I don't know whether this is bad or corner of spec