view functions extracted to source files should be excluded from scancode

[rabbah]

@chetanmeh i had run your gradle target at some point and because i also run a git commit hook, the generated files will fail my commit; we should exclude these files from code scan:

[./tools/dev/build/views/activations-byDate.js]:
       5: file does not end with EOL.
  [./tools/dev/build/views/all-whisks.v2.1.0-all.js]:
       8: line has trailing whitespaces.
      44: file does not end with EOL.
  [./tools/dev/build/views/logCleanup-byDateWithLogs.js]:
      15: file does not end with EOL.
  [./tools/dev/build/views/subjects-identities.js]:
      14: file does not end with EOL.
  [./tools/dev/build/views/whisks.v2.1.0-actions.js]:
      22: file does not end with EOL.
  [./tools/dev/build/views/whisks.v2.1.0-packages-public.js]:
       2: line has trailing whitespaces.
      17: file does not end with EOL.
  [./tools/dev/build/views/whisks.v2.1.0-packages.js]:
      19: file does not end with EOL.
  [./tools/dev/build/views/whisks.v2.1.0-rules.js]:
      12: file does not end with EOL.
  [./tools/dev/build/views/whisks.v2.1.0-triggers.js]:
      20: file does not end with EOL.

[markusthoemmes]

We should rather exclude build folders entirely. They are meant for generated artifacts.

[chetanmeh]

@rabbah I had made relevant exclude entry in scanConfig and it works for me. How does your commit hook setup looks like?

I saw this issue when commit hook was not passing the scanConfig path. See also #3295

[rabbah]

> cat .git/hooks/pre-commit
#!/usr/bin/env bash

set -e

# format all scala soruce
echo "formatting scala source"
$OPENWHISK_HOME/tools/git/pre-commit-scalafmt-native.sh

# scan all other files for conformance
python $OPENWHISK_HOME/../incubator-openwhisk-utilities/scancode/scanCode.py .

[chetanmeh]

So it misses on passing the scanConfig. Can you try the changes mentioned in #3295 ?

[chetanmeh]

@rabbah Does the scanCode change suggested fixes this issue for you? Otherwise we can close this issue