Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre commit hook doc in wiki #3295

Closed
chetanmeh opened this issue Feb 16, 2018 · 1 comment
Closed

Update pre commit hook doc in wiki #3295

chetanmeh opened this issue Feb 16, 2018 · 1 comment
Assignees

Comments

@chetanmeh
Copy link
Member

Currently the wiki for contribution says the commit hook should be set like

$ cat /path/to/openwhisk/.git/hooks/pre-commit
#!/usr/bin/env bash
python /path/to/incubator-openwhisk-utilities/scancode/scanCode.py .

For me this was not stopping commits which changed build.gradle with no EOL. On checking with @csantanapr he suggested that commit hook should be something like

$ cat /path/to/openwhisk/.git/hooks/pre-commit
#!/usr/bin/env bash

# determine openwhisk base directory
root="$(git rev-parse --show-toplevel)"
python /path/to/incubator-openwhisk-utilities/scancode/scanCode.py . --config $root/tools/build/scanCode.cfg

As its not possible to open PR for wiki opening an issue for proposing the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants