-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENNLP-1366: Fix Training of MaxEnt Model with large corpora fails with java.io.UTFDataFormatException #427
Conversation
…ith java.io.UTFDataFormatException
opennlp-tools/src/main/java/opennlp/tools/ml/model/ModelParameterChunker.java
Show resolved
Hide resolved
@mawiesne This looks great! Thanks for the PR! I'd love to get this merged into the 2.1.0 release. |
the PR looks good, except for missing test cases! Can those be added ? |
@atarora I'll provide a basic JUnit test for the |
@atarora The JUnit test has 🛩️ and gives a 💯% line coverage for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mawiesne !
@jzonthemtn Could you trigger & approve the (build) workflow, 'cause I can't. Thx in advance. |
Done |
FYI and for completeness: I tested the patch against the German treebank resources available from: https://universaldependencies.org/#language.
|
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions for build issues and submit an update to your PR as soon as possible.