Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove maven 2 output parsing, cleanup and some parsing fixes #8265

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbien
Copy link
Member

@mbien mbien commented Feb 20, 2025

  • remove maven 2 specific output parsing
  • fix reactor summary parsing
  • disabled JavadocOutputProcessor since it doesn't do anything atm
  • code cleanup (dead code removal, Java 17 lang level simplifications)

reactor summary link on failure is working again (useful with --fail-at-end):

reactor-failure-link

@mbien mbien added Code cleanup Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Feb 20, 2025
@mbien mbien added this to the NB26 milestone Feb 20, 2025
@@ -294,13 +294,6 @@ private String readLine() throws IOException {
nextLine = line.substring(execEventIdx);
line = line.substring(0, execEventIdx);
}
if (line.startsWith("[INFO] Final Memory:")) { //NOI18N
Copy link
Member Author

@mbien mbien Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cstamas pretty sure this is a m2 relict. I do remember the line but since it isn't anywhere except here i suppose it was from m2 times?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is not logged anymore

 - remove maven 2 specific output parsing
 - fix reactor summary parsing
 - disabled JavadocOutputProcessor since it doesn't do anything atm
 - code cleanup
@mbien mbien force-pushed the remove-m2-output-parsing branch from ffca65f to da236cc Compare February 21, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Code cleanup Java [ci] enable extra Java tests (java.completion, java.source.base, java.hints, refactoring.java, form) Maven [ci] enable "build tools" tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants