Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent storing of CCCD's if peer is not bonded. #801

Closed
wants to merge 2 commits into from

Conversation

h2zero
Copy link
Contributor

@h2zero h2zero commented Apr 17, 2020

Currently a peer that we have paired with but not bonded will have it's
CCCD status stored. We should not store CCCD data unless bonded,
this will prevent that.

#788

h2zero added 2 commits April 17, 2020 13:29
Currently a peer that we have paired with but not bonded will have it's
CCCD status stored. We should not store CCCD data unless bonded,
this will prevent that.
@apache-mynewt-bot
Copy link

Style check summary

No suggestions at this time!

@rymanluk
Copy link
Contributor

@h2zero thanks for that PR, I see the issue now which is triggered when bonding is actually not used.
imho in such a case we shall not call ble_gatts_bonding_established() this is why there is BLE_HS_DBG_ASSERT(conn->bhc_sec_state.bonded)

I went ahead and did other fix - could you please try that?
#804

@h2zero
Copy link
Contributor Author

h2zero commented Apr 21, 2020

@rymanluk Many ways to skin a cat 😃. #804 is certainly a more correct way that I considered as well, I just didn't have the time and opted for a quick fix. I will close this in favor of yours.

@h2zero h2zero closed this Apr 21, 2020
@h2zero h2zero deleted the prevent-storing-cccd-unbonded branch April 28, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants