Skip to content

Commit

Permalink
nimble/gap: Remove notification for update process timeout.
Browse files Browse the repository at this point in the history
The connection parameter update process has a hard-coded 40-second timeout,
but in reality, the time it takes to complete a connection parameter might take longer, as it
depends on the connection interval and when controller deciders to do it.
This patch changes meaning of this 40 sec timer to be only a guard so the application
does not perform too many connection update parameter requests.
Now when timeout fires, application will not be notified about that and link will not be dropped.
  • Loading branch information
zacwbond committed Mar 26, 2020
1 parent 2e4d060 commit 0fe52eb
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion nimble/host/src/ble_gap.c
Original file line number Diff line number Diff line change
Expand Up @@ -1943,7 +1943,6 @@ ble_gap_update_timer(void)
ble_hs_unlock();

if (entry != NULL) {
ble_gap_update_notify(conn_handle, BLE_HS_ETIMEOUT);
ble_gap_update_entry_free(entry);
}
} while (entry != NULL);
Expand Down
3 changes: 0 additions & 3 deletions nimble/host/test/src/ble_gap_test.c
Original file line number Diff line number Diff line change
Expand Up @@ -2982,9 +2982,6 @@ TEST_CASE_SELF(ble_gap_test_case_update_timeout)
.max_ce_len = 456,
};

/* No L2CAP. */
ble_gap_test_util_update_no_l2cap_tmo(&params, 1);

/* L2CAP - Local unsupported; L2CAP timeout. */
ble_gap_test_util_update_l2cap_tmo(&params, BLE_ERR_UNKNOWN_HCI_CMD, 0, 0);

Expand Down

0 comments on commit 0fe52eb

Please sign in to comment.