Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Restore missing FAQ tutorial from website migration #18174

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Restore missing FAQ tutorial from website migration #18174

merged 2 commits into from
Apr 29, 2020

Conversation

ys2843
Copy link
Contributor

@ys2843 ys2843 commented Apr 27, 2020 •
edited
Loading

Description

According to Lin Yuan, #15517 was deleted from mxnet website and faq during the website migration. Restored this file in this PR.

Checklist

Essentials

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Restore missing tutorial Use TensorInspector to Help Debug Operators of FAQ
  • First PR - add my name to CONTRIBUTORS.md

Comments

@ys2843
Copy link
Contributor Author

ys2843 commented Apr 27, 2020

@mxnet-label-bot add [Website]

@ys2843
Copy link
Contributor Author

ys2843 commented Apr 27, 2020

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Apr 27, 2020
@ys2843
Copy link
Contributor Author

ys2843 commented Apr 27, 2020

@mxnet-bot run ci [sanity]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [sanity]

@ys2843
Copy link
Contributor Author

ys2843 commented Apr 27, 2020

@mxnet-bot run ci [sanity]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [sanity]

@leezu
Copy link
Contributor

leezu commented Apr 27, 2020

@ys2843 sanity build broke due to an update to pylint and it's dependency astroid. I'm fixing it as part of #18177

Once it is merged, you can retrigger sanity build to pass

apeforest
apeforest approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution!

@leezu
Copy link
Contributor

leezu commented Apr 28, 2020

@mxnet-bot run ci [sanity]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [sanity]

@ys2843
Copy link
Contributor Author

ys2843 commented Apr 28, 2020

Thank you guys for reviewing and fixing the check problem.

@ys2843 ys2843 requested a review from marcoabreu as a code owner April 28, 2020 04:51
@ys2843
Copy link
Contributor Author

ys2843 commented Apr 28, 2020

@mxnet-bot run ci [windows-gpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ys2843
Copy link
Contributor Author

ys2843 commented Apr 28, 2020

@mxnet-bot run ci [windows-gpu ]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@ys2843
Copy link
Contributor Author

ys2843 commented Apr 28, 2020

@mxnet-label-bot update [pr-awaiting-merge]

@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed Website pr-awaiting-review PR is waiting for code review labels Apr 28, 2020
apeforest
apeforest suggested changes Apr 29, 2020
View reviewed changes
@ys2843 ys2843 requested a review from eric-haibin-lin as a code owner April 29, 2020 04:31
@ys2843 ys2843 force-pushed the restoreMissingDocs branch from ff3b61c to f6583d6 Compare April 29, 2020 04:53
@ys2843 ys2843 requested a review from apeforest April 29, 2020 15:42
apeforest
apeforest approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick turnaround.

@apeforest apeforest merged commit 5206b54 into apache:master Apr 29, 2020
@ys2843 ys2843 deleted the restoreMissingDocs branch April 29, 2020 17:42
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@AntiZpvoh
Restore missing FAQ tutorial from website migration (apache#18174)
83ff7f6 
* restore missing docs from web migration

* first PR - add my name to contributors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@apeforest apeforest apeforest approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu

@eric-haibin-lin eric-haibin-lin Awaiting requested review from eric-haibin-lin

Assignees
No one assigned
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ys2843 @mxnet-bot @leezu @apeforest @lanking520