Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EXPERIMENT] Make CI use split repo #2030

Closed
wants to merge 8 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jan 7, 2025

And then reuse Central cache across jobs, while the rest (locally installed) are throwaway.

Changes:

  • rework CI to use MAVEN_ARGS to make all Maven invocations use split repo, CI caches now only central
  • EmbeddedExecutor is now equivalent to forked: it also observes MAVEN_ARGS env variable (forked was always, as it is mvn script invoked).
  • Helper test made "resilient" to split repo: it now asserts "ends with" as split repo may add prefixes to local repository paths.
  • Verifier methods made "repository aware" (null = installed, non-null = remote repositoryId)
  • Tests doing artifact LRM ops now need to be aware of their origin

Result of these changes should be drastically lower pulls from Central, ideally zero in fact (only when a dependency changes).

And then reuse Central cache across jobs, while
the rest (locally installed) are throwaway.
@cstamas cstamas requested a review from gnodet January 7, 2025 15:01
@cstamas cstamas self-assigned this Jan 7, 2025
@cstamas
Copy link
Member Author

cstamas commented Jan 8, 2025

Giving up this work, we still end up w/ dirty central caches as:

  • split repo is only about "repoId"
  • but many ITs redefine "central" as local file repo -> those would end up polluting cache
  • some ITs redefine "centra" with bringing up Jetty -> same thing as above, but goes over resolver

@cstamas cstamas closed this Jan 8, 2025
@cstamas cstamas deleted the experiment-split-repo branch January 8, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant