[MNG-7774] Maven config and command line interpolation #1098
Conversation
Reuse as much as possible from master, but keep existing stuff like multiModuleProjectDirectory alone. Changes: * interpolate user properties and arguments * introduce session.topDirectory and session.rootDirectory * Maven fails to start if any of the new properties are undefined but their use is attempted
| try { | ||
| topDirectory = topDirectory.toAbsolutePath().toRealPath(); | ||
| } catch (IOException e) { | ||
| System.err.println("Error computing real path from " + topDirectory); |
There was a problem hiding this comment.
Would it be easier to troubleshoot the problem if the exception information was printed out here?
There was a problem hiding this comment.
Agreed, included IOEx message as well
|
Does this actually supersede #1062? |
No, that one is for master and builds on top of already present new mvn4 features not present in 3.9.x. This PR is for 3.9.x and "mildly follows" the one you refer to, with reduced functionalities. For example, that one uses
|
|
Anyone else? |
|
@cstamas I think the description of adding this command in |
Which command? No command was added or modified in Maven CLI |
I had a change at one point I forgot about (Hamcrest matcher "is" vs "endsWith"). Implementation now behaves same as on master, so proper is "is".
Reuse as much as possible from master, but keep existing stuff like multiModuleProjectDirectory alone.
Changes:
https://issues.apache.org/jira/browse/MNG-7774