-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more compact display, drop now obsolete plugin compat #704
Conversation
content/markdown/docs/history.md.vm
Outdated
The last release is ${current39xVersion}, the Apache Maven team project will maintain core versions: | ||
- ${current39xVersion} | ||
- ${current38xVersion} | ||
The last release is currently ${current39xVersion}, the Apache Maven team project will currently maintain 2 core versions: **${current39xVersion}** and **${current38xVersion}**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 => two
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elliotte, there are no fixed rules about using numbers or words, but I agree here to keep it align in the article (in line 58 and on other parts of the page "two" is used, so we should do here too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as @michael-o :)
content/markdown/docs/history.md.vm
Outdated
The last release is ${current39xVersion}, the Apache Maven team project will maintain core versions: | ||
- ${current39xVersion} | ||
- ${current38xVersion} | ||
The last release is currently ${current39xVersion}, the Apache Maven team project will currently maintain 2 core versions: **${current39xVersion}** and **${current38xVersion}**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to Elliotte, there are no fixed rules about using numbers or words, but I agree here to keep it align in the article (in line 58 and on other parts of the page "two" is used, so we should do here too)
a8ec7c2
to
afdfe7e
Compare
https://maven.apache.org/docs/history.html