Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more compact display, drop now obsolete plugin compat #704

Merged
merged 1 commit into from
Feb 23, 2025

Conversation

hboutemy
Copy link
Member

@hboutemy hboutemy commented Feb 23, 2025

The last release is ${current39xVersion}, the Apache Maven team project will maintain core versions:
- ${current39xVersion}
- ${current38xVersion}
The last release is currently ${current39xVersion}, the Apache Maven team project will currently maintain 2 core versions: **${current39xVersion}** and **${current38xVersion}**.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 => two

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Elliotte, there are no fixed rules about using numbers or words, but I agree here to keep it align in the article (in line 58 and on other parts of the page "two" is used, so we should do here too)

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Copy link
Contributor

@Bukama Bukama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @michael-o :)

The last release is ${current39xVersion}, the Apache Maven team project will maintain core versions:
- ${current39xVersion}
- ${current38xVersion}
The last release is currently ${current39xVersion}, the Apache Maven team project will currently maintain 2 core versions: **${current39xVersion}** and **${current38xVersion}**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Elliotte, there are no fixed rules about using numbers or words, but I agree here to keep it align in the article (in line 58 and on other parts of the page "two" is used, so we should do here too)

@Bukama Bukama added the documentation Improvements or additions to documentation label Feb 23, 2025
@hboutemy hboutemy force-pushed the compact-core-policy branch from a8ec7c2 to afdfe7e Compare February 23, 2025 17:33
@hboutemy hboutemy merged commit 15ded04 into master Feb 23, 2025
1 of 2 checks passed
@hboutemy hboutemy deleted the compact-core-policy branch February 23, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants