Clarify types, extensions, and classifiers #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bukama
reviewed
Feb 21, 2025
| be set by the `classifier` element. This | ||
| table may be extended by plugins and extensions used in the build. | ||
|
|
||
| <!-- TODO what if an explicit classifier element conflicts with the |
There was a problem hiding this comment.
I suggest, we try to find out to leave no TODOs or create and issue for the TODO instead only having one in the code, where it gets forgotten.
elharo
commented
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this page https://maven.apache.org/repositories/artifacts.html very confusing and hard to follow, so I rewrote it to more clearly distinguish between element values and internal properties. I tried to tighten up the language and indicate that type handlers also affect classifiers.