-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNGSITE-539] Add Maven CI Friendly Versions to menu #594
Conversation
Note: Spotless was applied and IDE is set to the Maven code styles (for MD files esp. 120 chars per line). The files were not matching the code styles before (lines of 177 chars and more). That's why those file have so many changes :/ |
Can you split the PR so that we can review the reformat / actual changes ? |
Yeah sure. Opened #595 to just contain the formatting of the effected files. Will then rebase/redo the actual changes to add the guide to the menu etc. |
#595 merged |
The guide about Maven CI Friend Versions was integrated into the navigation menu. As it is a guide the file was moved to the guide section and renamed to match the naming schema of this folder. Therefor the release notes of Maven 3.5.0 (and its beta) was updated to the new links. Also some small formatting errors in those release notes were fixed in the same action.
cfc203e
to
455d611
Compare
Thank you, rebased this branch. |
* [MNG-6177] - The `--file` command line option of the Windows and Unix launchers does not work for directory names | ||
like " | ||
Spaces & Special Char" | ||
* [MNG-6177] - The `--file` command line option of the Windows and Unix launchers does not work for directory names like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but 9it does work on Macs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, maybe @cstamas @gnodet @slawekjaranowski do? To be fair the ticket was closed in 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not clear on why you're changing this at all. If you are then,
If you are using the previously named properties for a version in your pom, you have to use [flatten-maven-plugin to do an mvn install
or mvn deploy
. More details can be found at Maven CI Friendly Versions.
The guide about Maven CI Friend Versions was integrated into the navigation menu. As it is a guide, the file was moved to the guide section and renamed to match the naming schema of this folder. Therefor the release notes of Maven 3.5.0 (and its beta) was updated to the new links. Also some small formatting errors in those release notes were fixed in the same action.