Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNGSITE-539] Add Maven CI Friendly Versions to menu #594

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

Bukama
Copy link
Contributor

@Bukama Bukama commented Dec 15, 2024

The guide about Maven CI Friend Versions was integrated into the navigation menu. As it is a guide, the file was moved to the guide section and renamed to match the naming schema of this folder. Therefor the release notes of Maven 3.5.0 (and its beta) was updated to the new links. Also some small formatting errors in those release notes were fixed in the same action.

@Bukama
Copy link
Contributor Author

Bukama commented Dec 15, 2024

Note: Spotless was applied and IDE is set to the Maven code styles (for MD files esp. 120 chars per line). The files were not matching the code styles before (lines of 177 chars and more). That's why those file have so many changes :/

@gnodet
Copy link
Contributor

gnodet commented Dec 16, 2024

Can you split the PR so that we can review the reformat / actual changes ?

@Bukama
Copy link
Contributor Author

Bukama commented Dec 16, 2024

Can you split the PR so that we can review the reformat / actual changes ?

Yeah sure. Opened #595 to just contain the formatting of the effected files. Will then rebase/redo the actual changes to add the guide to the menu etc.

@slawekjaranowski
Copy link
Member

#595 merged

The guide about Maven CI Friend Versions was integrated into the navigation menu.
As it is a guide the file was moved to the guide section and renamed to match the naming schema of this folder.
Therefor the release notes of Maven 3.5.0 (and its beta) was updated to the new links.
Also some small formatting errors in those release notes were fixed in the same action.
@Bukama Bukama force-pushed the mngsite539_cifriendly branch from cfc203e to 455d611 Compare December 23, 2024 08:51
@Bukama
Copy link
Contributor Author

Bukama commented Dec 23, 2024

#595 merged

Thank you, rebased this branch.

@elharo elharo changed the title #MNGSITE-539 Add Maven CI Friendly Versions to menu [MNGSITE-539] Add Maven CI Friendly Versions to menu Dec 23, 2024
* [MNG-6177] - The `--file` command line option of the Windows and Unix launchers does not work for directory names
like "
Spaces & Special Char"
* [MNG-6177] - The `--file` command line option of the Windows and Unix launchers does not work for directory names like
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but 9it does work on Macs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, maybe @cstamas @gnodet @slawekjaranowski do? To be fair the ticket was closed in 2017

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not clear on why you're changing this at all. If you are then,

If you are using the previously named properties for a version in your pom, you have to use [flatten-maven-plugin to do an mvn install
or mvn deploy. More details can be found at Maven CI Friendly Versions.

@slawekjaranowski slawekjaranowski merged commit 335ee8a into apache:master Dec 23, 2024
@Bukama Bukama deleted the mngsite539_cifriendly branch December 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants