Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup and verify dependencies #128

Merged
merged 5 commits into from
Dec 24, 2024
Merged

Cleanup and verify dependencies #128

merged 5 commits into from
Dec 24, 2024

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 2, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 2, 2024 16:14
@elharo elharo marked this pull request as draft December 2, 2024 16:19
@elharo elharo marked this pull request as ready for review December 2, 2024 16:41
</goals>
<configuration>
<failOnWarning>true</failOnWarning>
<ignoredDependencies>junit:junit:*,org.apache.maven:maven-compat:*,org.apache.maven.resolver:maven-resolver-connector-basic:*,org.apache.maven.resolver:maven-resolver-transport-wagon:*,org.apache.maven.wagon:wagon-http-lightweight:*</ignoredDependencies>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use a list of tags for separate items

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean multiple ignoredDependencies elements, one per artifact?

Comment on lines +103 to +118
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-dependency-plugin</artifactId>
<executions>
<execution>
<id>analyze</id>
<goals>
<goal>analyze-only</goal>
</goals>
<configuration>
<failOnWarning>true</failOnWarning>
<ignoredDependencies>org.slf4j:slf4j-simple:*</ignoredDependencies>
</configuration>
</execution>
</executions>
</plugin>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try to put it in root pom ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't buy very much since we still need to configure the ignoredDependencies on a project by project basis. That allows us to omit the goals and failOnWarning elements, but nothing else.

@slachiewicz slachiewicz added dependencies Pull requests that update a dependency file maintenance labels Dec 24, 2024
@elharo elharo merged commit ab8c5aa into master Dec 24, 2024
51 checks passed
@elharo elharo deleted the deps branch December 24, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants