[MEAR-194] Use ear archiver instead of jar archiver

[santik]

In plugin instead of correct EAR archiver JAR archiver was used.
In this PR application will use correct archiver.

[pzygielo]

On fb2a47c I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR: Deployment descriptor: .../maven-ear-plugin/target/test-classes/projects/project-054/target/maven-ear-plugin-test-project-054-99.0/META-INF/application.xml does not exist. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR
...
[ERROR] Errors: 
[ERROR]   EarMojoIT.testProject054:652->AbstractEarPluginIT.doTestProject:184->AbstractEarPluginIT.doTestProject:169->AbstractEarPluginIT.doTestProject:144->AbstractEarPluginIT.executeMojo:128->AbstractEarPluginIT.executeMojo:97 » Verification

[santik]

On fb2a47c I got

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR: Deployment descriptor: .../maven-ear-plugin/target/test-classes/projects/project-054/target/maven-ear-plugin-test-project-054-99.0/META-INF/application.xml does not exist. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-ear-plugin:3.1.0-SNAPSHOT:ear (default-ear) on project maven-ear-plugin-test-project-054: Error assembling EAR
...
[ERROR] Errors: 
[ERROR]   EarMojoIT.testProject054:652->AbstractEarPluginIT.doTestProject:184->AbstractEarPluginIT.doTestProject:169->AbstractEarPluginIT.doTestProject:144->AbstractEarPluginIT.executeMojo:128->AbstractEarPluginIT.executeMojo:97 » Verification

You are right. Sometimes we still need to use JAR archiver. Updated the code.

[elharo]

This needs a test

[hboutemy]

question: what does an ear archiver do differently from a jar archiver that brings concrete benefit, please?

[santik]

@hboutemy it is described in the ticket as showing incorrect message
however I think it is better to use correct implementation instead of generic jar archiver when it is possible

[hboutemy]

ok, now I get that the message is written by the archiver, not by the plugin
adn from a pure theoretical perspective, a more dedicated archiver can help in some cases but given the plugin worked perfectly with simple jar, I need to clarify if any ear archiver feature won't conflict
but sure, I'll rework the provided patch to fix the current conflict with master, if you don't beat me at it :)

[santik]

@hboutemy sure! I've just resolved conflicts, but if you have anything to add- do it

[hboutemy]

given there is a test later that checks and fail if the descriptor does not exist, it seems this case is not really useful, isn't it?

[santik]

file is not required for the jar archiver, but required for ear

[hboutemy]

I tested and found that starting with JavaEE 5, descriptor is not required: but currently, EarArchiver is implemented in a way that does not support this condition
ok, now I see how we must either improve EarArchiver, either do the workaround you did: I'll merge and document the workaround

[santik]

ok
I fixed conflicts again

[hboutemy]

merged and updated to document the unexpectedly complex logic for an issue that we supposed was up-for-grabs... :)

thank you everybody for your help and efforts