[MEAR-287] - Refactoring of logging when modifying manifest of EAR mo…

…dules
apache · Oct 2, 2020 · 304c4b3 · 304c4b3
1 parent 5bcdf4c
commit 304c4b3
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/src/main/java/org/apache/maven/plugins/ear/EarMojo.java b/src/main/java/org/apache/maven/plugins/ear/EarMojo.java
@@ -749,19 +749,21 @@ private void changeManifestClasspath( EarModule module, File original, JavaEEVer
                 // Create a temporary work directory
                 // MEAR-167 use uri as directory to prevent merging of artifacts with the same artifactId
                 workDirectory = new File( new File( getTempFolder(), "temp" ), module.getUri() );
-                if ( workDirectory.isDirectory() || workDirectory.mkdirs() )
+                if ( !workDirectory.isDirectory() )
                 {
-                    getLog().debug( "Created a temporary work directory: " + workDirectory.getAbsolutePath() );
-
-                    // Unpack the archive to a temporary work directory
-                    zipUnArchiver.setSourceFile( original );
-                    zipUnArchiver.setDestDirectory( workDirectory );
-                    zipUnArchiver.extract();
-                }
-                else
-                {
-                    throw new MojoFailureException( "Failed to create directory " + workDirectory );
+                    if ( workDirectory.mkdirs() )
+                    {
+                        getLog().debug( "Created a temporary work directory: " + workDirectory.getAbsolutePath() );
+                    }
+                    else
+                    {
+                        throw new MojoFailureException( "Failed to create directory " + workDirectory );
+                    }
                 }
+                // Unpack the archive to a temporary work directory
+                zipUnArchiver.setSourceFile( original );
+                zipUnArchiver.setDestDirectory( workDirectory );
+                zipUnArchiver.extract();
             }
             else
             {