Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDEPLOY-279] Better validation for alt deploy repository mojo parameter #12

Closed
wants to merge 6 commits into from
Closed

[MDEPLOY-279] Better validation for alt deploy repository mojo parameter #12

wants to merge 6 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Dec 10, 2020 •
edited
Loading

Do accept proper format ONLY, for legacy provide "solution" and
fail with meaningful error message.

https://issues.apache.org/jira/browse/MDEPLOY-279

@cstamas cstamas self-assigned this Dec 10, 2020
michael-o
michael-o reviewed Dec 11, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this looks sound, should we rather switch to non-greedy matches should could have avoided this from the start? See my comment in JIRA.

@cstamas
Copy link
Member Author

cstamas commented Dec 11, 2020

I literally copy+pasted m-d-p regexp from 2.x to be 100% sure it is what it is (to match exactly what 2.x did match). Also, IMHO this IF-ELSE clearly explains what and why happens. Is redundant, but buys it out at clarity IMO.

@michael-o
Copy link
Member

OK, let me think about this. If we can make it even more idiotproof then we should do it.

@cstamas
MDEPLOY-279: Better validation for alt deploy repository mojo parameter
578d82f 
Do not accept anything but expected format.

Fail always if not expected alt repo string passed in, but improve
error messages best possible.

IF legacy used, provide useful error message giving solution as well.
@cstamas cstamas force-pushed the MDEPLOY-279-validation branch from 0d78f76 to 578d82f Compare December 12, 2020 13:00
@michael-o
Copy link
Member

Thanks, will look into new changes.

mickroll
mickroll approved these changes Dec 18, 2020
View reviewed changes
Copy link

@mickroll mickroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@michael-o
Copy link
Member

Going through now...

michael-o
michael-o requested changes Dec 20, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed two small changes and left a few open issue, but I general I like the approach.

@michael-o
Copy link
Member

Looks good to me now, I will run tests again!

@asfgit asfgit closed this in 92d7e74 Dec 20, 2020
@michael-o
Copy link
Member

Thanks for bearing with me...

@cstamas cstamas mentioned this pull request Dec 22, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o requested changes

@slachiewicz slachiewicz slachiewicz approved these changes

@mickroll mickroll mickroll approved these changes

@khmarbaise khmarbaise Awaiting requested review from khmarbaise

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cstamas @michael-o @slachiewicz @mickroll