Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacetAssociations #848

Merged
merged 2 commits into from
Apr 29, 2022
Merged

LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacetAssociations #848

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4756a67
LUCENE-10530: Avoid floating point precision bug in TestTaxonomyFacet…
gsmiller Apr 27, 2022
3cb7c68
need to still use a delta on the aggregate value since the order chil…
gsmiller Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetAssociations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,10 +500,7 @@ private void validateFloats(
assertNull(facetResult);
} else {
assertEquals(dim, facetResult.dim);
// We can expect the floats to be exactly equal here since we're ensuring that we sum them
// in the same order when determining expected values and when computing facets. See
// LUCENE-10530:
assertEquals(aggregatedValue, facetResult.value.floatValue(), 0f);
assertEquals(aggregatedValue, facetResult.value.floatValue(), 1f);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I was going to comment this in the last iteration. There may also be some internal drift in the way aggregation function works on floats. Found a nice read on it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing!

assertEquals(expected.size(), facetResult.childCount);
}
}
Expand Down