LUCENE-10040 Correct TestHnswGraph.testSearchWithAcceptOrds #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we set numSeed = 10, this test fails sometimes because it may mark expected results docs (from 0 to 9) as deleted which don't end up being retrieved, resulting in a low recall - set numSeed to 10 to ensure 10 results are returned - add startIndex paramenter to createRandomAcceptOrds that allows documents before startIndex to be NOT deleted - use startIndex equal to 10 for createRandomAcceptOrds Relates to apache#239
jtibshirani
approved these changes
Sep 3, 2021
lucene/core/src/test/org/apache/lucene/util/hnsw/TestHnswGraph.java
Outdated
Show resolved
Hide resolved
b184eee to
35ee89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we set numSeed = 10, this test fails sometimes because it may mark
expected results docs (from 0 to 9) as deleted which don't end up
being retrieved, resulting in a lower than expected recall.
createRandomAcceptOrdsthat allowsdocuments before startIndex to be NOT deleted
equal to 10 for createRandomAcceptOrds
Relates to #239