-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish build scans to develocity.apache.org #14140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there anything we need to do from our side to merge this (gh secrets)?
No, the secret already exists. The build scan will not publish from this PR, since my fork cannot access the secret, but post merge the secret is accessible. You can see this from other projects like Beam which access the secret and are successfully publishing build scans. |
Thanks @clayburn |
* Publish build scans to develocity.apache.org * Update Develocity plugin versions * Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org`
Applied to main and branch_10x. |
I had to revert this patch, unfortunately. Something doesn't work after changes have been merged - see the actions here: |
@@ -13,7 +13,7 @@ on: | |||
- 'branch_10x' | |||
|
|||
env: | |||
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these env specs are missing "secrets."; should be "secrets.DEVELOCITY_ACCESS_KEY"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly it. Let me better test this on my fork and re-open.
This PR migrates the Lucene project to publish Build Scans to the the new Develocity instance at develocity.apache.org.
Additionally, this PR migrates from the legacy Gradle Enterprise plugin to the renamed Develocity plugin and sets a projectId for use by Develocity.