Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish build scans to develocity.apache.org #14140

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

clayburn
Copy link
Contributor

@clayburn clayburn commented Jan 14, 2025

This PR migrates the Lucene project to publish Build Scans to the the new Develocity instance at develocity.apache.org.

Additionally, this PR migrates from the legacy Gradle Enterprise plugin to the renamed Develocity plugin and sets a projectId for use by Develocity.

Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there anything we need to do from our side to merge this (gh secrets)?

@clayburn
Copy link
Contributor Author

No, the secret already exists. The build scan will not publish from this PR, since my fork cannot access the secret, but post merge the secret is accessible. You can see this from other projects like Beam which access the secret and are successfully publishing build scans.

@dweiss dweiss merged commit 34a732f into apache:main Jan 15, 2025
@dweiss
Copy link
Contributor

dweiss commented Jan 15, 2025

Thanks @clayburn

@dweiss dweiss modified the milestones: 11.0.0, 10.1.1 Jan 15, 2025
dweiss pushed a commit that referenced this pull request Jan 15, 2025
* Publish build scans to develocity.apache.org

* Update Develocity plugin versions

* Use `DEVELOCITY_ACCESS_KEY` to authenticate to `develocity.apache.org`
@dweiss
Copy link
Contributor

dweiss commented Jan 15, 2025

Applied to main and branch_10x.

@clayburn clayburn deleted the develocity.apache.org branch January 15, 2025 12:52
dweiss added a commit that referenced this pull request Jan 15, 2025
dweiss added a commit that referenced this pull request Jan 15, 2025
@dweiss
Copy link
Contributor

dweiss commented Jan 15, 2025

I had to revert this patch, unfortunately. Something doesn't work after changes have been merged - see the actions here:
https://github.com/apache/lucene/actions/runs/12788491292

@@ -13,7 +13,7 @@ on:
- 'branch_10x'

env:
GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these env specs are missing "secrets."; should be "secrets.DEVELOCITY_ACCESS_KEY"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's exactly it. Let me better test this on my fork and re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants