-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade commons codec from 1.13.0 to 1.16.0 #13269
base: main
Are you sure you want to change the base?
Conversation
I think i understand the 1.16.1 issue. Looks like there is a bit of jar/maven-hell going on among the commons dependencies. I hit it when I tried to upgrade commons-compress... Bumping both of them to the latest version is not the solution, it seems to then just cause "module-hell" and still fails the build. But for now we can get them on less ancient versions. |
I will open a separate issue for the commons-compress as there is more trouble there... |
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
I figured out what broke in commons-codec 1.16.1 and reported an issue over there: https://issues.apache.org/jira/projects/CODEC/issues/CODEC-324 |
Note that the current version of Commons Codec is 1.17.1. |
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Note that I pushed a new version of Commons Codec a couple of days ago. |
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the dev@lucene.apache.org list. Thank you for your contribution! |
Currently, we depend upon a pre-COVID version of commons-codec (like several other dependencies, I am working the issues).
Upgrade to 1.16.0.
NOTE: I'm unable to upgrade to 1.16.1: it causes test failures.
Seems some resources are missing from the jar or similar.
I tried to investigate a bit, by looking at their source code changes from 1.16.0 to 1.16.1, it is overwhelming, not exactly what I'd call a "patch" release :)
apache/commons-codec@rel/commons-codec-1.16.0...rel/commons-codec-1.16.1
Either way, that isn't to be fixed here, so let's at least move from a 2019 version to a 2023 version. We can separately debug the 1.16.1 issue / report it to them / file a PR /etc.