Speed up writeGroupVInts #13203
Merged
Speed up writeGroupVInts #13203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
approved these changes
Mar 25, 2024
| return Integer.BYTES - (Integer.numberOfLeadingZeros(v | 1) >> 3); | ||
| } | ||
|
|
||
| public static void writeGroupVInts(DataOutput out, byte[] scratch, long[] values, int limit) |
There was a problem hiding this comment.
Can you add some minimal javadocs?
|
Thanks for reviewing! |
jpountz
approved these changes
Mar 25, 2024
# Conflicts: # lucene/CHANGES.txt
asfgit
pushed a commit
that referenced
this pull request
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses
VarHandlesinstead ofBytesRefBuilder#appendto speed upwriteGroupVInts, which is more aligned with group-varint generally implementation.Main:
PR: