DRAFT: Vectorize ForUtil encoding for the 9.0 codec (same format) #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9.0 codec (only encode!). It should show as example how it works, this is not ready for productions, although all tests pass
|
Important: I don't intend to merge this, it just shows WIP. |
uschindler
commented
Jul 3, 2023
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java
Show resolved
Hide resolved
# Conflicts: # lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java
|
What's also missing in the code: Some randomized test that feeds both implementations with random data and verifies that both results are identical. |
|
to run this branch with vectorization enabled: $ export CI=true
$ export RUNTIME_JAVA_HOME=/path/to/jdk20or21
$ gradlew :lucene:core:test |
|
Thanks for putting this together @uschindler. I'm going to move my experiments over to a clone of this branch. |
|
Now that we are removing patching for the doc block encoding maybe vectorizing decode of these blocks is more palatable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT: This uses code from #12396 to vectorize ForUtil for the 9.0 codec (only encode!). It should show as example how it works, this is not ready for productions, although all tests pass.