Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forUtil.gradle to actually execute python script and also fix type error in script #12411

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

uschindler
Copy link
Contributor

When we ported the build to gradle, the forUtil generator script was never executed, because the script name was missing as argument. Actually the script was also buggy, because it produced type error (with newer python versions)

@uschindler uschindler requested review from dweiss and jpountz July 3, 2023 13:26
@uschindler uschindler self-assigned this Jul 3, 2023
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... was it like this since the very beginning?! Darn. Strange. Thanks, Uwe.

@uschindler
Copy link
Contributor Author

Hmm... was it like this since the very beginning?! Darn. Strange. Thanks, Uwe.

I checked history of that file, no change since the beginning.

@uschindler uschindler merged commit f668cfd into apache:main Jul 3, 2023
@uschindler uschindler deleted the pr/fixForUtilGenerator branch July 3, 2023 14:22
asfgit pushed a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants