Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GITHUB-12181: fix false-positive TestKnnFloatVectorQuery.testDocAndScoreQueryBasics() failure #12182

Merged
merged 1 commit into from
Mar 6, 2023
Merged

GITHUB-12181: fix false-positive TestKnnFloatVectorQuery.testDocAndScoreQueryBasics() failure #12182

merged 1 commit into from
Mar 6, 2023

Conversation

cpoerschke
Copy link
Contributor

for #12181 issue

@kaivalnp kaivalnp mentioned this pull request Mar 4, 2023
Merged
@msokolov
Copy link
Contributor

msokolov commented Mar 5, 2023

Thanks, @cpoerschke !

benwtrent
benwtrent approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I will close my PR: #12189

didn't see this one :) thanks @cpoerschke !

@cpoerschke cpoerschke merged commit 3bd06b1 into apache:main Mar 6, 2023
@cpoerschke cpoerschke deleted the issue-12181 branch March 6, 2023 15:29
asfgit pushed a commit that referenced this pull request Mar 6, 2023
@cpoerschke
GITHUB-12181: fix false-positive TestKnnFloatVectorQuery.testDocAndSc…
caf55e0 
…oreQueryBasics() failure (#12182)

(cherry picked from commit 3bd06b1)

Resolved Conflicts:
	lucene/core/src/test/org/apache/lucene/search/TestKnnFloatVectorQuery.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwtrent benwtrent benwtrent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpoerschke @msokolov @benwtrent