Create a bot to check if there is a CHANGES entry for new PRs

[stefanvodita]

Description

We always have to remind ourselves and others to add a CHANGES entry. We can probably write a GitHub action to check for changes to that file on every new PR and leave a comment warning the author if that's missing.

[prudhvigodithi]

Here is the sample PR with change-log verifier action added prudhvigodithi#1, we can add the same workflow to lucene repo. But I see the error dangoslen/changelog-enforcer@v3 is not allowed to be used in apache/lucene.

[javanna]

Yes to this! It would be great to combine this with setting the milestone :)

[stefanvodita]

@prudhvigodithi - I opened #13898 inspired by your PR, tested it on my fork, and it's working correctly.
@javanna - I like that idea! Maybe we can do that as a follow-up.

[stefanvodita]

I was looking at the workflow that @pseudo-nymous wrote. The logs for #14276 say there is no CHANGES entry. We'll need to fix that. I've also added the PR number to the output (#14324), since I couldn't see it anywhere.

Edit: Same issue in the logs for #14320.
Edit: We even have runs that error out.

[pseudo-nymous]

Thanks for updating the script with PR number. I'll root cause and fix the issue.

[stefanvodita]

@pseudo-nymous, I've attempted a fix in #14355.

[pseudo-nymous]

Thanks @stefanvodita! I will take a look at the fix and propose changes accordingly.

[dweiss]

dangoslen/changelog-enforcer@v3 is not allowed to be used in apache/lucene

Apache projects are not allowed to use arbitrary actions for security reasons, please take a look at:
https://infra.apache.org/github-actions-policy.html#External%5C%20actions

[stefanvodita]

Just to clarify - the restriction @dweiss mentioned applies to the changelog-enforcer action, but not to the checkout action we are using.

@pseudo-nymous - I'm seeing new failures now, e.g. a fatal.
It's frustrating that the tests we perform on our forks aren't reflective of the behaviour we see in the main repo.

[pseudo-nymous]

@stefanvodita I have added a fix for it. Please take a look. #14369