Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe rename DaciukMihovAutomatonBuilder? #12276

Closed
mikemccand opened this issue May 8, 2023 · 5 comments · Fixed by #12310
Closed

Maybe rename DaciukMihovAutomatonBuilder? #12276

mikemccand opened this issue May 8, 2023 · 5 comments · Fixed by #12310

Comments

@mikemccand
Copy link
Member

Description

Spinoff from this dev list thread.

This delightful class very efficiently takes a set of terms and produces the already determinized and minimized Automaton matching exactly those terms.

I appreciate that the name comes from the authors of the paper that explained this algorithm (thank you!!), but I would like to name it something more approachable to new users so they get a hint about what this powerful class actually does.

Any suggestions?

@dweiss
Copy link
Contributor

dweiss commented May 8, 2023

StringSetAutomatonBuilder?

@uschindler
Copy link
Contributor

I thought this class was already renamed to MinimizeSchindlerDeterminizer? 😂

@mikemccand
Copy link
Member Author

StringSetAutomatonBuilder?

Hmm can we remove Set? (It could be a list or array of String too). Maybe StringsToAutomaton?

@dweiss
Copy link
Contributor

dweiss commented May 9, 2023

A list or an array - doesn't matter, conceptually it's a set in the end (in the automaton). But I don't mind any version.

@gsmiller
Copy link
Contributor

+1 to StringsToAutomaton language. I'd suggest keeping "Builder" in the name.

In general, also +1 to renaming. The algorithm doesn't have to only be applied to strings (e.g., it could directly be applied to binary data, as long as it's sorted). So having something that references "string" in the name feels right to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants