-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maybe rename DaciukMihovAutomatonBuilder
?
#12276
Comments
StringSetAutomatonBuilder? |
I thought this class was already renamed to |
Hmm can we remove |
A list or an array - doesn't matter, conceptually it's a set in the end (in the automaton). But I don't mind any version. |
+1 to In general, also +1 to renaming. The algorithm doesn't have to only be applied to strings (e.g., it could directly be applied to binary data, as long as it's sorted). So having something that references "string" in the name feels right to me. |
Description
Spinoff from this dev list thread.
This delightful class very efficiently takes a set of terms and produces the already determinized and minimized Automaton matching exactly those terms.
I appreciate that the name comes from the authors of the paper that explained this algorithm (thank you!!), but I would like to name it something more approachable to new users so they get a hint about what this powerful class actually does.
Any suggestions?
The text was updated successfully, but these errors were encountered: